Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use reflection when creating gRPC responses #8588

Closed
4 tasks
robert-zaremba opened this issue Feb 15, 2021 · 3 comments
Closed
4 tasks

Don't use reflection when creating gRPC responses #8588

robert-zaremba opened this issue Feb 15, 2021 · 3 comments

Comments

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Feb 15, 2021

Summary

There was a bug in CLI. TL;DR: all requests must go through ABCI. It was solved in #8549

Problem Definition

The current solution is using reflection to construct the response for CLI. This adds an extra roundtrip.

Proposal

Create factory methods to construct the concrete type.
Ref: #8549 (comment)

Alternative approach is to avoid the serialization and wrap the abci.Response: #8549 (comment)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@tac0turtle
Copy link
Member

@robert-zaremba is this still present even though we don't route through tendermint anymore?

@robert-zaremba
Copy link
Collaborator Author

I think this is already solved. Let's also confirm with @AmauryM

@amaury1093
Copy link
Contributor

Yeah I don't think we use reflection in baseapp anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants