Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MsgTransfer a convenience wrapper around SendPacket rpc #6949

Closed
3 tasks
colin-axner opened this issue Jul 25, 2024 · 0 comments
Closed
3 tasks

Make MsgTransfer a convenience wrapper around SendPacket rpc #6949

colin-axner opened this issue Jul 25, 2024 · 0 comments
Assignees
@bznein
Labels
20-transfer type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
05-port refactor ...

Comments

@colin-axner
Copy link
Contributor

Summary

With the introduction of the SendPacket api, MsgTransfer should become a convenience wrapper which translates its user inputted arguments into a ics20 transfer packet. All necessary checks for ics20 should be moved into OnSendPacket

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added 20-transfer type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. labels Jul 25, 2024
@colin-axner colin-axner added this to the 05-port refactor alpha milestone Jul 25, 2024
@bznein bznein mentioned this issue Aug 7, 2024
Merged
10 tasks
@bznein bznein closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bznein bznein

Labels
20-transfer type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Status: Done 🥳
Milestone
05-port refactor alpha
Development

No branches or pull requests
2 participants
@bznein @colin-axner