Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded source files #255

Closed
ViktorHofer opened this issue Nov 30, 2018 · 1 comment
Closed

Embedded source files #255

ViktorHofer opened this issue Nov 30, 2018 · 1 comment

Comments

@ViktorHofer
Copy link
Contributor

There is the option in roslyn to embed source files directly into the pdb. Is support plan to handle such scenarios? In corefx we are missing source files from System.Private.CoreLib which is located in another repository (coreclr). If we would embed the sources directly into the pdb we could mitigate this issue but that requires support from both coverlet and ReportGenerator.

dotnet/roslyn#19127

cc @danmosemsft @stephentoub

@ViktorHofer
Copy link
Contributor Author

ViktorHofer commented Nov 30, 2018

Closing as it seems not work needs to be done here in favor of SourceLink: https://github.com/dotnet/corefx/issues/30974#issuecomment-443273154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant