Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also update branch in badges section with the git tag #26

Closed
Arnavion opened this issue Mar 2, 2017 · 2 comments
Closed

Also update branch in badges section with the git tag #26

Arnavion opened this issue Mar 2, 2017 · 2 comments
Assignees

Comments

@Arnavion
Copy link

Arnavion commented Mar 2, 2017

The new [badges] section has a branch to specify which branch / tag's status should be displayed on crates.io. When cargo-release bumps the version and creates the git tag, it could also update the branch specifier for every badge in this section to the git tag of the new release; then that the manifest of the published crate will link to the badge for that release.

Refs:

rust-lang/crates.io#504
rust-lang/cargo#3546
http://doc.crates.io/manifest.html#package-metadata
https://www.integer32.com/2017/01/20/categories-and-ci-badges.html

@sunng87
Copy link
Collaborator

sunng87 commented Mar 3, 2017

Good idea! This is what the badge should be displayed on crates.io. Keeping it to master doesn't make much sense IMO. Added to my backlog and will definitely implement this for cargo-release. Thank you!

@sunng87 sunng87 self-assigned this Mar 3, 2017
@sunng87
Copy link
Collaborator

sunng87 commented Apr 2, 2017

This is supported in 0.8.0 beta releases via configuration in Cargo.toml like:

https://github.com/sunng87/cargo-release/blob/master/Cargo.toml#L23

You can search and replace any file during release process, use {{version}} as placeholder of new version number.

@sunng87 sunng87 closed this as completed Apr 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants