Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friends Feature - Tap to dismiss name editing #162

Closed
lennet opened this issue Oct 19, 2019 · 4 comments
Closed

Friends Feature - Tap to dismiss name editing #162

lennet opened this issue Oct 19, 2019 · 4 comments

Comments

@lennet
Copy link
Member

lennet commented Oct 19, 2019

Bildschirmfoto 2019-10-19 um 10 16 06

It would be nice if its possible to dismiss the keyboard after editing the name on tapping anywhere on the screen instead of just the return key. We had that already implemented but removed it because the old implementation conflicted with the tableviews cell selection.

All the work friends feature can be found in the Friends feature branch

@lennet
Copy link
Member Author

lennet commented Oct 19, 2019

Editing currently crashes but it should work again after #161 got merged

@lennet lennet mentioned this issue Oct 19, 2019
6 tasks
@besilva
Copy link
Contributor

besilva commented Oct 19, 2019

Can I work on this issue?

@lennet
Copy link
Member Author

lennet commented Oct 19, 2019

Hey @besilva, Sure, we appreciate support on any issue! You can open a draft pr and link it against the issue to show other contributors that you are working on the issue

@besilva
Copy link
Contributor

besilva commented Oct 20, 2019

Done it

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants