Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friends Feature - UITests #164

Closed
lennet opened this issue Oct 19, 2019 · 2 comments · Fixed by #261
Closed

Friends Feature - UITests #164

lennet opened this issue Oct 19, 2019 · 2 comments · Fixed by #261

Comments

@lennet
Copy link
Member

lennet commented Oct 19, 2019

It would be nice to have UITests for testing the full flow of adding a friend through opening a link (example link: criticalmaps:follow?token=TestKey&name=TestName) and deleting it afterwards in the friends view.

All the work friends feature can be found in the Friends feature branch

@lennet lennet mentioned this issue Oct 19, 2019
6 tasks
@besilva
Copy link
Contributor

besilva commented Oct 19, 2019

Can I work on this?

@fbernutz
Copy link
Member

@besilva Do you still want to work on that?

The setup for working with the Friends feature changed a bit.
The Friends feature is already merged on master but hidden with a feature toggle. To activate the feature toggle, you could use a new launch argument like ACTIVATE_FRIENDS in the UITest similar to the existing SKIP_ANIMATIONS. In the AppDelegate.swift you could activate the feature toggle when the specific launch argument is set.

if ProcessInfo.processInfo.arguments.contains("ACTIVATE_FRIENDS") {
    var feature = Feature.friends
    feature.isActive = true
}

With this setup you can ensure that the feature toggle is activated in the UITest.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants