Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform merging of select queries by constructing and executing query plan #97

Open
cswinter opened this issue Dec 20, 2018 · 0 comments
Labels
good first issue Good for newcomers

Comments

@cswinter
Copy link
Owner

There is one remaining place during query execution which is performed "manually" rather than by constructing and executing a query plan:

// TODO(clemens): make this work for differently aliased columns (need to send through query planner)

Mostly this just requires moving the Data::append_all function into a VectorOperator and corresponding QueryPlan variant and then constructing a query plan in the same fashion as all the other cases for merging batches.

@cswinter cswinter added the good first issue Good for newcomers label Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant