Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

dotnet tools should work in F# projects #184

Closed
ctaggart opened this issue Mar 27, 2017 · 4 comments
Closed

dotnet tools should work in F# projects #184

ctaggart opened this issue Mar 27, 2017 · 4 comments

Comments

@ctaggart
Copy link
Owner

@enricosada, I'm not having much luck with F# as compared to C#. Here is the test case:

git clone git@github.com:ctaggart/sourcelink-test.git

# csharp
cd sourcelink-test\ClassLibrary1
msbuild /t:restore
dotnet sourcelink
msbuild /t:build /p:ci=true

# fsharp
cd ..\Library1
msbuild /t:restore
dotnet sourcelink
msbuild /t:build /p:ci=true

csharp works while fsharp dies with:

No executable found matching command "dotnet-sourcelink"

Any ideas? Any suggestions on trying newer stuff that may fix this?

@enricosada
Copy link

no ideas, but i'll check locally why doesnt work.
probably the f# target for old fsproj doesnt include the new nuget target (who support PackageReference and DotnetCliTool)

@ctaggart ctaggart changed the title support F# dotnet tools should work in F# projects Mar 31, 2017
@ctaggart
Copy link
Owner Author

ctaggart commented Apr 1, 2017

@enricosada Should I open up a ticket somewhere else like visualfsharp repo?

@ctaggart
Copy link
Owner Author

ctaggart commented May 1, 2017

FSharp.NET.Sdk 1.0.3 now supports the new fsproj files. https://twitter.com/enricosada/status/857275876668563456

I'm going to promote SourceLink.Create.CommandLine instead, so closing this anyway.

@ctaggart ctaggart closed this as completed May 1, 2017
@enricosada
Copy link

sry if i was late @ctaggart . i didnt find the issue at first check and i forgot about it, sry

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants