AllowedOutputExtensionsInPackageBuildOutputFolder .pdb

[ctaggart]

@jnm2 mentioned a nice workaround for the pdb packing problem NuGet/Home#4142 (comment)

<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>

Can/should we just incorporate this?

[jnm2]

Incorporate into a package published from this repo, or just incorporate into the codebase here?

I can't count the number of MSBuild workaround snippets I've posted around the place in the last year so I think of each as a hopefully very temporary stopgap till the SDKs get their act together. Reserving a NuGet package name for each shortcoming of an SDK isn't the first thing that comes to my mind. But neither do I have anything against someone else doing so. 😃

[ctaggart]

I was thinking directly into the targets.

[jnm2]

Ah, I'm sorry for being slow. You'd just add it to all the .targets of the existing packages you publish?
(Can I vote for .props so I can override it in a .csproj if I feel like it?)

[ctaggart]

Correct, existing packages. Yes, props is the right way.

[ctaggart]

I'll tag a 2.6.0 after this is fixed. FYI, I expect SourceLink to get a lot of attention tomorrow.

[jnm2]

FYI, I expect SourceLink to get a lot of attention tomorrow.

Oh? ...oh, congratulations! =D

[jnm2]

I did not know this:

AllowedOutputExtensionsInPackageBuildOutputFolder requires VS 2017 15.4 / .NET Core 2.0.2 SDK to work. Perhaps VSTS hasn't updated yet?

NuGet/Home#4142 (comment)

Does that change anything?

[ctaggart]

No, as long as it is benign.

[ctaggart]

I released 2.6.0 with the previous changes. I added this information to the readme.

[ctaggart]

@jnm2, any chance you could look at #291? It isn't working for me at the moment and I'm not sure why. No rush.

[ctaggart]

Fixed by #291.