Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dollywood / Silver Dollar City, opening hours not found #310

Open
HookDonn opened this issue Aug 3, 2020 · 1 comment
Open

Dollywood / Silver Dollar City, opening hours not found #310

HookDonn opened this issue Aug 3, 2020 · 1 comment
Labels
API Change An external API has changed, requiring a library update

Comments

@HookDonn
Copy link

HookDonn commented Aug 3, 2020

Park
All parks Herschend (Dollywood & Silver Dollar City)

Context

  • themeparks version used: 5.1.39
  • Operating System: Ubuntu 19.04 (GNU/Linux 5.0.0-20-generic x86_64)

How to find your themeparks version:
Linux: npm list --depth=0 | grep themeparks
Windows CMD: npm list | find "themeparks"
PowerShell: npm list | sls themeparks

Describe the bug
The opening hours of the 2 Herschend parks have not been noted. From my console output (see below), I conclude that there is certainly an error in the code but I am unable to fix it. It would be cool if someone could look, I don't think it's hard to fix. Thanks !

Output
TypeError: scheduleData.forEach is not a function
at FetchOpeningTimes.HTTP.then (/home/container/node_modules/themeparks/lib/herschend/herschendparkbase.js:105:20)
at process._tickCallback (internal/process/next_tick.js:68:7)

@cubehouse cubehouse added the API Change An external API has changed, requiring a library update label Aug 18, 2020
@BorupJoshua
Copy link

I have a temporary solution to this issue. It seems that Dollywood and Silver Dollar City have moved their calendar APIs to their own respective websites, as such the URL I am using for Silver Dollar City is

"https://www.silverdollarcity.com/api/cxa/DailySchedule/GetDailySchedule?did={687E9C32-0FAC-4F7E-A48B-5676DC4242D3}&hsi=True&dt=False&sd=" with a date appended to the end.
I believe the date format is as follows "YYYY-MM-DD" It provides a JSON file with the opening and closing hours of the park if it exists.

However, if the park is not set to open, it will not be present on the JSON file. I do not fully know if you can swap out silverdollarcity for dollywood to grab Dollywood's park times, but seeing as both websites are similar in styles I would expect it would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Change An external API has changed, requiring a library update
Projects
None yet
Development

No branches or pull requests

3 participants