Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errorMessage and errorStack functions are not found #1582

Closed
code4muktesh opened this issue Feb 18, 2021 · 5 comments · Fixed by #1732
Closed

errorMessage and errorStack functions are not found #1582

code4muktesh opened this issue Feb 18, 2021 · 5 comments · Fixed by #1732
Labels
good first issue Good for newcomers 🙏 help wanted Help wanted - not prioritized by core team ⚡ enhancement Request for new functionality

Comments

@code4muktesh
Copy link

In the v5 and V6, errorMessage and errorStack was present as
https://github.com/cucumber/cucumber-js/blob/v6.0.5/src/formatter/get_color_fns.js#L22

With v7 unable to find the same.
https://github.com/cucumber/cucumber-js/blob/master/src/formatter/get_color_fns.ts#L32

@aslakhellesoy
Copy link
Contributor

Why is this a problem?

@code4muktesh
Copy link
Author

@aslakhellesoy we had written some custom formatter with v5/6 and using errorMessage and errorStack functions to handle error logs. Now, migrating to v7 so trying to find the same.

@aurelien-reeves aurelien-reeves added 🙏 help wanted Help wanted - not prioritized by core team ⚡ enhancement Request for new functionality good first issue Good for newcomers labels Apr 15, 2021
@aurelien-reeves
Copy link
Contributor

aurelien-reeves commented Apr 15, 2021

I think if you submit a PR to bring those back - and also the other missing ones - there are good chances that it would be accepted ☺

@davidjgoss
Copy link
Contributor

You could also consider using colors directly, given that errorMessage just delegates to colors.red.

@aurelien-reeves
Copy link
Contributor

aurelien-reeves commented Apr 15, 2021

@davidjgoss that was my first though too

Then I looked at custom formatters documentation, and we easily find the get_color_fns module, so it could be considered as public api. Thus, maybe @code4muktesh is not the only one facing that issue. That is why I suggested to bring those props back as part of a good first issue for new contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers 🙏 help wanted Help wanted - not prioritized by core team ⚡ enhancement Request for new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants