Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Netlify deployment of Ladle #12

Closed
davidjgoss opened this issue Jan 14, 2022 · 9 comments
Closed

Add Netlify deployment of Ladle #12

davidjgoss opened this issue Jan 14, 2022 · 9 comments
Assignees

Comments

@davidjgoss
Copy link
Contributor

davidjgoss commented Jan 14, 2022

Would be great to have the latest Storybook Ladle deployed, but also to have deploy previews of pull requests so reviewers can easily try out the changes.

@davidjgoss
Copy link
Contributor Author

@mattwynne @aslakhellesoy is there a netlify account we can use to set this up? We use it for the docs site too, right?

@aurelien-reeves
Copy link
Contributor

I think Netlify would be "too much" for simply hosting storybook.
I am pretty sure we could do something using github actions and github pages.

To answer your question: yes, we have a Netlify account for the documentation website, so if you really want to use Netlify, we can set that up ;)

@davidjgoss
Copy link
Contributor Author

@aurelien-reeves if there's something I haven't seen for doing the equivalent of deploy previews with GH actions+pages that would be great!

@aurelien-reeves
Copy link
Contributor

Oh, you were interesting in the "review" thing!
Indeed, I don't know such possibilities yet with github pages

@davidjgoss davidjgoss changed the title Add Netlify deployment of Storybook Add Netlify deployment of Ladle Nov 13, 2022
@davidjgoss
Copy link
Contributor Author

@mattwynne we discussed Netlify a bit the other day in the context of websites - would you mind adding me to the relevant Cucumber team so I can set this up? GitHub email address is the one.

@mattwynne
Copy link
Member

mattwynne commented Nov 16, 2023

@davidjgoss unfortunately I don't have privileges in the SmartBear Netlify org to do that. I'll ping @declark who does, to ask him if he can help.

@declark
Copy link

declark commented Nov 16, 2023

@mattwynne and @davidjgoss of course I can help! Please send me what you need, and I'll take care of it.

@mattwynne
Copy link
Member

Thanks @declark - I just sent you an email with the details.

@davidjgoss
Copy link
Contributor Author

This is set up now, thanks all.

it will need #337 in order to deploy successfully, working on that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants