Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update curlconverter #1

Open
verhovsky opened this issue Apr 7, 2022 · 2 comments
Open

Update curlconverter #1

verhovsky opened this issue Apr 7, 2022 · 2 comments

Comments

@verhovsky
Copy link
Member

verhovsky commented Apr 7, 2022 •
edited
Loading

Currently, the extension ships curlconverter v3. We can’t upgrade because v4 uses top-level await statements, so it must be an ES module (ESM), but VS Code doesn’t support ES modules in extensions:

electron/electron#21457

microsoft/vscode#201935 (released as VS Code 1.88)
@verhovsky verhovsky mentioned this issue Apr 9, 2022
Merged
@verhovsky verhovsky mentioned this issue Jul 21, 2022
Closed
@verhovsky verhovsky mentioned this issue Apr 15, 2023
Open
@stevennyman
Copy link

Looks like ESM will ship in Electron 28 (scheduled for stable release December 5) so hopefully VSCode will support it soon afterwards.

@verhovsky
Copy link
Member Author

microsoft/vscode#130367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@verhovsky @stevennyman