-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove '-I.', and include headers using the relative path #3044
Comments
We have ~50 (by crude search) source files that At the moment, they get the correct assertions (ours) because of our abuse of So, as part of fixing all the |
WIP branch here (nothing to see yet): https://github.com/cyrusimap/cyrus-imapd/compare/master..elliefm:cyrus-imapd:v39/3044-include-cleanup |
This gets more complicated, because some headers get installed so that other code can be linked against libcyrus et al. These headers get installed to wherever they get installed to, with no extra So, even though spelling these includes as |
I started this a long time ago, in 39dab7c, because our generated headers need their directory to be explicit to be correctly found during certain types of builds (which
make distcheck
checks, and therefore we need to succeed).And it's fine having that comment in files that need those headers, but every so often we need to add a generated header to a file that doesn't already have any, and this detail gets missed and breaks distcheck again.
We can avoid tripping over this repeatedly by removing -I. completely, and updating every file to name its includes explicitly.
The text was updated successfully, but these errors were encountered: