From 7b60e622b44ac0f73a5df4970ea332bb0aad8073 Mon Sep 17 00:00:00 2001 From: Maciej Holyszko <14310995+falkenhawk@users.noreply.github.com> Date: Wed, 2 Nov 2022 17:33:16 +0100 Subject: [PATCH] fix messing the order of messages when posting to a git platform. The order of messages without file/line data were being reversed, but **only** when posting to a git platform e.g. github. --- source/dsl/DangerResults.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/source/dsl/DangerResults.ts b/source/dsl/DangerResults.ts index 1a65c7f10..b964fff54 100644 --- a/source/dsl/DangerResults.ts +++ b/source/dsl/DangerResults.ts @@ -190,6 +190,9 @@ export function sortInlineResults(inlineResults: DangerInlineResults[]): DangerI export function sortResults(results: DangerResults): DangerResults { const sortByFile = (a: Violation, b: Violation): number => { + if (a.file === undefined && b.file === undefined) { + return 0; + } if (a.file === undefined) { return -1 } @@ -198,10 +201,13 @@ export function sortResults(results: DangerResults): DangerResults { } if (a.file == b.file) { - if (a.line == undefined) { + if (a.line === undefined && b.line === undefined) { + return 0; + } + if (a.line === undefined) { return -1 } - if (b.line == undefined) { + if (b.line === undefined) { return 1 }