Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress jumps in 2.3 #57

Open
Igor-Palaguta opened this issue Jun 9, 2015 · 4 comments
Open

Progress jumps in 2.3 #57

Igor-Palaguta opened this issue Jun 9, 2015 · 4 comments

Comments

@Igor-Palaguta
Copy link

Animation jumps if animation is not completed yet and we set new progress value.
Even incorrect value can be set, like in mentioned above example:
self.progressView.setProgress(1.0, animated: true)
//....and when I call during animation progress
self.progressView.setProgress(0.5, animated: false)
last call initiates remove of animation. And it calls animationDidStop delegate method asynchronously, even after proper progress is set. So after 0.5 is set, 1.0 will be set in animationDidStop in a moment

Version 2.2 without animation delegate works fine

@peterpaulis
Copy link

i can confirm that

@woodsnick
Copy link

Look like this change broke that:

a7f5352

The issue is that this bit of code was moved inside the else and not executed in the animated block:

  •    self.circularProgressLayer.progress = pinnedProgress;
    

Moving it out of the else again fixes the issue.

@AcidicSkittles
Copy link

+1

@iamyellow
Copy link

hi guys! FYI hi tried to make that change but didn't work, but I manage to solve it, look the PR:
#67

hope it helps.

BTW, sometimes animations don't work at all, but I don't know exactly when and so why, because any of the progress views in the app work, so maybe is related somehow w/ the network layer... but I would say it started to happen when updated to >= 2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants