-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async local function issues #591
Comments
The changes in #590 should also improve the method names. The result is not perfect, since Also the method names are not yet perfect, but give the new version a try. |
Thanks, I'll take a deeper look hopefully this week. I see, nested classes or async methods might be hard to even impossible to distinguish from the strings that are in the cobertura files. I'll try to think about a solution as well. |
Okay so I finally got some time to take a look into this... I'm trying to find various differences between Coverlet and |
You can open a new issue or reuse this one. Does not matter. |
It seems that C# local functions are not counted as methods by ReportGenerator, and as such don't have their own line in the Metrics table. Not sure if this is intended, but it doesn't work consistently all the time, anyway.
No local function here:
When I, however, use some more complex code, local functions do appear in the metrics, however with an improperly parsed name. I wanted to provide some sample outputs, but don't have much time to properly dig into that right now, so I at least provide some code that can be used for testing:
I'm using
dotnet-reportgenerator-globaltool
v5.1.17 and the Cobertura format. I tried bothdotnet-coverage
tool and Coverlet, both of which resulted in an incorrect behavior. Their behavior might be the same when #590 is fixed.The text was updated successfully, but these errors were encountered: