Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selective copy paste: copy from lower instance of module overwrites higher instance on paste #16376

Closed
wpferguson opened this issue Feb 24, 2024 · 2 comments

Comments

@wpferguson
Copy link
Member

Describe the bug

If you have 2 instances of a module, change the lower (in pixelpipe) instance, then copy and paste it to another image with both instances, the higher (in pixelpipe) instance is changed. If the instance has a label, the label is not changed so there isn't an indication that the incorrect instance got the change applied to it.

Tested the copy both instances work around that I found with #16375 and it works here also.

Steps to reproduce

  1. Open an image with 2 instances of tone equalizer and change the lower to compress dynamic range.
    before

  2. Selectively copy the lower instance.
    copy

  3. Paste the copy and then notice the upper instance changed, but the label remained the same.
    after

Expected behavior

apply the change to the corresponding instance

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

4.7.0+630~gb0ebf97c59

What OS are you using?

Linux

What is the version of your OS?

ubuntu 22.04

Describe your system?

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

@TurboGit
Copy link
Member

This is expected to me or there is something I don't understand. If you copy a single instance then when pasting we see a single instance which gets pasted :

  • In the first non hand named instance
  • Or in a new instance is all instances are named

@s7habo
Copy link

s7habo commented Feb 25, 2024

I can't reproduce it with #16373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants