Highlight reconstruction mode "Clip highlights" affects non-clipped areas of image

[dhoulder]

Describe the bug

Enabling the "clip highlights" mode of highlight reconstruction causes some bright but not clipped areas of some images to change colour.

With highlight reconstruction off:

With highlight reconstruction on and clip-highlights selected:

Notice the yellow patch left of the pole.

None of this area is clipped according to the RGB-checkerboard indicator or the clipping indicator display in the highlight reconstruction panel.

Other highlight reconstruction methods seem to work fine.

The observed colour artefact is present regardless of OpenCL being enabled or disabled.

Steps to reproduce

Download IMG_2993.CR2.xmp and IMG_2993.CR2 from https://drive.google.com/drive/folders/1EQhxbbEgB_c0zXTNUR_uEi0UvZ_5Y1eA?usp=sharing

Import into darktable

Toggle highlight reconstruction module on and off and observe bright region left of pole

Expected behavior

Highlight reconstruction should not affect unclipped areas

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

self compiled

darktable version

4.8.1

What OS are you using?

Linux

What is the version of your OS?

Ubuntu 22.04

Describe your system?

XFCE desktop (X11), 8Gb RAM, gtk

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

nvidia P620 roprietary driver 535

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

[jenshannoschwalm]

There is the mask indicator in highlights module showing a false-color representation of photo sites considered to be above threshold.

[dhoulder]

Hi @jenshannoschwalm. Yes, but when I switch it on it shows nothing is clipped (see screenshot above). Same for the RGB checkerboard clipping warning button below the image.

[jenshannoschwalm]

Ah, it's due to as-shot-to-reference in White-Balance module. I will fix that asap.