From 76bbc39ee30c8b394def6696904d08b0dddeb9e6 Mon Sep 17 00:00:00 2001 From: Istvan Soos Date: Mon, 26 Aug 2024 14:43:40 +0200 Subject: [PATCH] Enable reporting without the experimental cookie. --- CHANGELOG.md | 1 + app/lib/frontend/handlers/experimental.dart | 2 +- app/test/frontend/golden/pkg_changelog_page.html | 3 ++- app/test/frontend/golden/pkg_install_page.html | 3 ++- app/test/frontend/golden/pkg_score_page.html | 3 ++- app/test/frontend/golden/pkg_show_page_discontinued.html | 3 ++- app/test/frontend/golden/pkg_show_page_flutter_plugin.html | 3 ++- app/test/frontend/golden/pkg_show_page_publisher.html | 3 ++- app/test/frontend/golden/pkg_show_page_retracted.html | 3 ++- .../golden/pkg_show_page_retracted_non_retracted_version.html | 3 ++- app/test/frontend/golden/pkg_versions_page.html | 3 ++- app/test/frontend/golden/publisher_activity_log_page.html | 3 ++- app/test/frontend/golden/publisher_admin_page.html | 3 ++- app/test/frontend/golden/publisher_unlisted_packages_page.html | 3 ++- 14 files changed, 26 insertions(+), 13 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e0f07b165..637ff5414 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ AppEngine version, listed here to ease deployment and troubleshooting. * Bumped runtimeVersion to `2024.08.23`. * Upgraded stable Flutter analysis SDK to `3.24.1`. * Upgraded dartdoc to `8.0.14`. + * Note: the `report` experiment is enabled by default. ## `20240821t093600-all` * Bumped runtimeVersion to `2024.08.20`. diff --git a/app/lib/frontend/handlers/experimental.dart b/app/lib/frontend/handlers/experimental.dart index 0e8587391..26d7f1dbb 100644 --- a/app/lib/frontend/handlers/experimental.dart +++ b/app/lib/frontend/handlers/experimental.dart @@ -84,7 +84,7 @@ class ExperimentalFlags { return params; } - bool get isReportPageEnabled => isEnabled('report'); + bool get isReportPageEnabled => true; bool get isDarkModeEnabled => isEnabled('dark'); bool get isDarkModeDefault => isEnabled('dark-as-default'); diff --git a/app/test/frontend/golden/pkg_changelog_page.html b/app/test/frontend/golden/pkg_changelog_page.html index 0cde45d80..0ecc84413 100644 --- a/app/test/frontend/golden/pkg_changelog_page.html +++ b/app/test/frontend/golden/pkg_changelog_page.html @@ -388,7 +388,8 @@

More