Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update incorrect_msg in has_expr when set_context/set_env used #317

Open
filipsch opened this issue Jul 13, 2018 · 1 comment
Open

Update incorrect_msg in has_expr when set_context/set_env used #317

filipsch opened this issue Jul 13, 2018 · 1 comment
Labels
enhancement messages

Comments

@filipsch
Copy link
Contributor

filipsch commented Jul 13, 2018 •
edited
Loading

Currently, the context variable values or environment variable values are not included in the automatically generated message, which can be confusing.
@filipsch filipsch self-assigned this Jul 13, 2018
@filipsch filipsch mentioned this issue Jul 30, 2018
Closed
@filipsch filipsch changed the title Update incorrect_msg in has_expr when set_context used Update incorrect_msg in has_expr when set_context/set_env used Aug 8, 2018
@filipsch filipsch mentioned this issue Aug 8, 2018
Closed
@filipsch filipsch removed their assignment Sep 13, 2018
@filipsch filipsch mentioned this issue Sep 27, 2018
Open
@hermansje
Copy link
Member

We should probably always mention the context/env when it is set (also when calling a function with check_call, rerunning a body with check_body().has_equal_output(), checking the value of an argument with check_args('x')...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement messages
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hermansje @filipsch