Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Image Naming Scheme for iPad @2x #19

Closed
winkelsdorf opened this issue Sep 21, 2015 · 1 comment
Closed

Wrong Image Naming Scheme for iPad @2x #19

winkelsdorf opened this issue Sep 21, 2015 · 1 comment

Comments

@winkelsdorf
Copy link

Hi,

The images for iPad have wrong names. Wondering why nobody stumbled upon this earlier?

I created my own Activity for Chrome and searched why it's size was different compared to TUSafariActivity when on iPad.

screenshot 2015-09-21 20 33 05

Both TUSafariActivity Images, safariiPad.png and safariiPad@2x.png have the correct size, 76x76px and 152x152px. The padding is also equal to my own Chrome Images (20px transparent Pixels around the Icon on @2x).

screenshot 2015-09-21 20 44 57

To track it down I manipulated the iPad Image:
screenshot 2015-09-21 20 36 26

Guess what: The iPad Image is never loaded. The Simulator and Device were wrong as in the initial Image ;)

tl;dr
You're doing it wrong. iPad Images are not meant to be named by a Scheme of "iPad@2x" but "@2xiPad". See http://stackoverflow.com/a/9627825/844907. It's been a long time since I had to deal with such kind of a Bug. That was fun to track it down ^^

I'll create a PR for renaming the Assets.

Thanks for TUSafariActivity, beside this little glitch a great help!

Edit: By the way, in PR #14 it was done right.

Cheers,
Frederik

@winkelsdorf
Copy link
Author

Fixed with merge 0a73696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant