vsp: Add missing mutex locks.

decred · Apr 24, 2023 · a8f2b05 · a8f2b05
1 parent b646752
commit a8f2b05
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/internal/vsp/feepayment.go b/internal/vsp/feepayment.go
@@ -849,7 +849,9 @@ func (fp *feePayment) submitPayment() (err error) {
 			if err != nil {
 				log.Errorf("error abandoning expired fee tx %v", err)
 			}
+			fp.mu.Lock()
 			fp.feeTx = nil
+			fp.mu.Unlock()
 		}
 		return fmt.Errorf("payfee: %w", err)
 	}
@@ -922,7 +924,10 @@ func (fp *feePayment) confirmPayment() (err error) {
 	case "confirmed":
 		fp.remove("confirmed by VSP")
 		// nothing scheduled
-		err = w.UpdateVspTicketFeeToConfirmed(ctx, &fp.ticketHash, &fp.feeHash, fp.client.URL, fp.client.PubKey)
+		fp.mu.Lock()
+		feeHash := fp.feeHash
+		fp.mu.Unlock()
+		err = w.UpdateVspTicketFeeToConfirmed(ctx, &fp.ticketHash, &feeHash, fp.client.URL, fp.client.PubKey)
 		if err != nil {
 			return err
 		}

diff --git a/internal/vsp/vsp.go b/internal/vsp/vsp.go
@@ -386,7 +386,7 @@ func (c *Client) TrackedTickets() []*TicketInfo {
 	}
 	c.mu.Unlock()
 
-	tickets := make([]*TicketInfo, 0, len(c.jobs))
+	tickets := make([]*TicketInfo, 0, len(jobs))
 	for _, job := range jobs {
 		job.mu.Lock()
 		tickets = append(tickets, &TicketInfo{