From 9417bfc314796088b56270f95d7e1e2ed2336964 Mon Sep 17 00:00:00 2001 From: Cassey Lottman Date: Tue, 4 May 2021 14:01:43 -0500 Subject: [PATCH 1/6] feat: deprecate autocomplete appropriate check --- lib/checks/forms/autocomplete-appropriate.json | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/checks/forms/autocomplete-appropriate.json b/lib/checks/forms/autocomplete-appropriate.json index 93ddb96061..dda69e3b06 100644 --- a/lib/checks/forms/autocomplete-appropriate.json +++ b/lib/checks/forms/autocomplete-appropriate.json @@ -1,6 +1,7 @@ { "id": "autocomplete-appropriate", "evaluate": "autocomplete-appropriate-evaluate", + "deprecated": true, "metadata": { "impact": "serious", "messages": { From 6093067894935247bd7f6cd0f36073cbb4db2454 Mon Sep 17 00:00:00 2001 From: Cassey Lottman Date: Mon, 17 May 2021 10:34:46 -0500 Subject: [PATCH 2/6] make autocomplete-appropriate a minor violation since it's deprecated --- lib/checks/forms/autocomplete-appropriate.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/checks/forms/autocomplete-appropriate.json b/lib/checks/forms/autocomplete-appropriate.json index dda69e3b06..145983ac54 100644 --- a/lib/checks/forms/autocomplete-appropriate.json +++ b/lib/checks/forms/autocomplete-appropriate.json @@ -3,7 +3,7 @@ "evaluate": "autocomplete-appropriate-evaluate", "deprecated": true, "metadata": { - "impact": "serious", + "impact": "minor", "messages": { "pass": "the autocomplete value is on an appropriate element", "fail": "the autocomplete value is inappropriate for this type of input" From d8b8e847eee09ea1b154096670fff6305e84b37f Mon Sep 17 00:00:00 2001 From: Cassey Lottman Date: Mon, 17 May 2021 10:40:35 -0500 Subject: [PATCH 3/6] remove deprecated autocomplete-appropriate check from autocomplete-valid rule --- lib/rules/autocomplete-valid.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rules/autocomplete-valid.json b/lib/rules/autocomplete-valid.json index 14d8de7c27..c57a350145 100644 --- a/lib/rules/autocomplete-valid.json +++ b/lib/rules/autocomplete-valid.json @@ -6,7 +6,7 @@ "description": "Ensure the autocomplete attribute is correct and suitable for the form field", "help": "autocomplete attribute must be used correctly" }, - "all": ["autocomplete-valid", "autocomplete-appropriate"], + "all": ["autocomplete-valid"], "any": [], "none": [] } From 8897603539130b8872b6bcad85a0758593e25fb7 Mon Sep 17 00:00:00 2001 From: Cassey Lottman Date: Mon, 17 May 2021 11:58:54 -0500 Subject: [PATCH 4/6] impact should still be severe --- lib/checks/forms/autocomplete-appropriate.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/checks/forms/autocomplete-appropriate.json b/lib/checks/forms/autocomplete-appropriate.json index 145983ac54..dda69e3b06 100644 --- a/lib/checks/forms/autocomplete-appropriate.json +++ b/lib/checks/forms/autocomplete-appropriate.json @@ -3,7 +3,7 @@ "evaluate": "autocomplete-appropriate-evaluate", "deprecated": true, "metadata": { - "impact": "minor", + "impact": "serious", "messages": { "pass": "the autocomplete value is on an appropriate element", "fail": "the autocomplete value is inappropriate for this type of input" From 56b4fc956cdb06506fa9faf2fb151d37968322c0 Mon Sep 17 00:00:00 2001 From: Cassey Lottman Date: Mon, 17 May 2021 12:06:35 -0500 Subject: [PATCH 5/6] update tests --- .../autocomplete-valid/autocomplete-valid.html | 7 ------- .../autocomplete-valid/autocomplete-valid.json | 11 +---------- .../virtual-rules/autocomplete-valid.js | 14 -------------- 3 files changed, 1 insertion(+), 31 deletions(-) diff --git a/test/integration/rules/autocomplete-valid/autocomplete-valid.html b/test/integration/rules/autocomplete-valid/autocomplete-valid.html index 3d2f59643e..8586c9179c 100644 --- a/test/integration/rules/autocomplete-valid/autocomplete-valid.html +++ b/test/integration/rules/autocomplete-valid/autocomplete-valid.html @@ -25,9 +25,6 @@ - - - @@ -149,10 +146,6 @@ - - - - diff --git a/test/integration/rules/autocomplete-valid/autocomplete-valid.json b/test/integration/rules/autocomplete-valid/autocomplete-valid.json index 3aa97971fd..2a1869272a 100644 --- a/test/integration/rules/autocomplete-valid/autocomplete-valid.json +++ b/test/integration/rules/autocomplete-valid/autocomplete-valid.json @@ -1,16 +1,7 @@ { "description": "autocomplete-valid tests", "rule": "autocomplete-valid", - "violations": [ - ["#fail1"], - ["#fail2"], - ["#fail3"], - ["#fail4"], - ["#fail5"], - ["#fail6"], - ["#fail7"], - ["#fail8"] - ], + "violations": [["#fail1"], ["#fail2"], ["#fail3"], ["#fail4"]], "passes": [ ["#pass1"], ["#pass2"], diff --git a/test/integration/virtual-rules/autocomplete-valid.js b/test/integration/virtual-rules/autocomplete-valid.js index aeb2df1ae1..8c1c5ea268 100644 --- a/test/integration/virtual-rules/autocomplete-valid.js +++ b/test/integration/virtual-rules/autocomplete-valid.js @@ -40,18 +40,4 @@ describe('autocomplete-valid virtual-rule', function() { assert.lengthOf(results.violations, 1); assert.lengthOf(results.incomplete, 0); }); - - it('should fail when autocomplete is incorrectly used', function() { - var results = axe.runVirtualRule('autocomplete-valid', { - nodeName: 'input', - attributes: { - type: 'color', - autocomplete: 'email' - } - }); - - assert.lengthOf(results.passes, 0); - assert.lengthOf(results.violations, 1); - assert.lengthOf(results.incomplete, 0); - }); }); From 16fef2c041e07b9d45114def0e89cd04f3a58d98 Mon Sep 17 00:00:00 2001 From: Cassey Lottman Date: Tue, 25 May 2021 09:35:27 -0500 Subject: [PATCH 6/6] remove act-mapping test that fails but shouldn't --- test/act-mapping/autocomplete-valid.json | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 test/act-mapping/autocomplete-valid.json diff --git a/test/act-mapping/autocomplete-valid.json b/test/act-mapping/autocomplete-valid.json deleted file mode 100644 index 1d2f796d4b..0000000000 --- a/test/act-mapping/autocomplete-valid.json +++ /dev/null @@ -1,5 +0,0 @@ -{ - "id": "73f2c2", - "title": "autocomplete attribute has valid value", - "axeRules": ["autocomplete-valid"] -}