Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file to bring me as name not working #575

Closed
kendonB opened this issue Jun 11, 2019 · 2 comments · Fixed by #637
Closed

file to bring me as name not working #575

kendonB opened this issue Jun 11, 2019 · 2 comments · Fixed by #637
Labels
Bug Unexpected behavior from existing features. Caster Issues pertaining to primarily the Caster project.

Comments

@kendonB
Copy link
Collaborator

kendonB commented Jun 11, 2019

Saying "file to bring me as file name" currently adds the folder name in the file dialog to the file section of the bringme.toml file. I'm actually not sure if there is a feasible way to allow bring me add to work for files.

Unless someone has an idea of how to achieve this, we should disable file as an option for bring me add. Perhaps a nice middle ground would be to have the bringme.toml file open at the location of the new line.

Other ideas are welcome.

@comodoro
Copy link
Contributor

What it did was take highlighted text, assume it is a file path and add it to things to launch. I suppose this functionality could be restored, plus check if file exists, plus maybe actually detecting current file if in Windows Explorer

@LexiconCode LexiconCode added Bug Unexpected behavior from existing features. Caster Issues pertaining to primarily the Caster project. labels Jun 18, 2019
@kendonB
Copy link
Collaborator Author

kendonB commented Jul 1, 2019

I have a "Copy as path" in the context menu on mine with keyboard shortcut "a". So fixing this could be as simple as doing Key("s-f10, a") which also looks like it works for folders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unexpected behavior from existing features. Caster Issues pertaining to primarily the Caster project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants