From 2012238848d3dc7bc9c6b45ad46164bc0add6e5b Mon Sep 17 00:00:00 2001 From: Zac Sweers Date: Thu, 15 Aug 2019 02:11:40 -0400 Subject: [PATCH 1/2] Try annotating as outputfiles too --- .../main/java/com/diffplug/gradle/spotless/SpotlessTask.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java b/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java index 80faec9d24..4088403427 100644 --- a/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java +++ b/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java @@ -34,6 +34,7 @@ import org.gradle.api.GradleException; import org.gradle.api.tasks.Input; import org.gradle.api.tasks.InputFiles; +import org.gradle.api.tasks.OutputFiles; import org.gradle.api.tasks.TaskAction; import org.gradle.api.tasks.incremental.IncrementalTaskInputs; @@ -118,6 +119,7 @@ public void setTarget(Iterable target) { /** Internal use only. */ @InputFiles + @OutputFiles @Deprecated public Iterable getInternalTarget() { // used to combine the special cache file and the real target From 10a908d964425097d0c956cd9c492f75052da647 Mon Sep 17 00:00:00 2001 From: Zac Sweers Date: Mon, 19 Aug 2019 20:57:03 -0400 Subject: [PATCH 2/2] Separate output and input --- .../com/diffplug/gradle/spotless/SpotlessTask.java | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java b/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java index 4088403427..eef52f64f0 100644 --- a/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java +++ b/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java @@ -119,9 +119,19 @@ public void setTarget(Iterable target) { /** Internal use only. */ @InputFiles + @Deprecated + public Iterable getInternalTargetInput() { + return getInternalTarget(); + } + + /** Internal use only. */ @OutputFiles @Deprecated - public Iterable getInternalTarget() { + public Iterable getInternalTargetOutput() { + return getInternalTarget(); + } + + private Iterable getInternalTarget() { // used to combine the special cache file and the real target return Iterables.concat(ImmutableList.of(getCacheFile()), target); }