Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Javenode and/or JNpm #934

Open
nedtwigg opened this issue Sep 15, 2021 · 0 comments
Open

Investigate Javenode and/or JNpm #934

nedtwigg opened this issue Sep 15, 2021 · 0 comments

Comments

@nedtwigg
Copy link
Member

Right now, we integrate with node.js formatting tasks by finding a Node.js and NPM installation on the host machine

  • using npm to install the required formatter, usually prettier, which is slow (npm task up-to-date checking too slow #766)
    • JNPM might be able to do this better
  • starting a localhost server in java, and another in node.js, and passing strings back and forth between them
    • Javenode would allow us to do this in-process.
      • Upside: fancy module intercepting which could cooperate with something like JNPM
      • Upside: passing strings within-process would be faster, but this is minor
      • Upside: don't need to futz with Spotless finding a node.js installation
      • Downside: can't futz with Spotless using a specific node.js installation which might match other non-java tooling

I don't plan to work on any of this, but I think #766 is a big problem. If anyone wants to experiment with the above, they are very welcome to! An important part for getting a PR merged will be a real-world project, where you can say "it was X seconds before, and it's Y seconds now". I don't want to swap things just to swap them.

If there's an easy way to keep the old mechanism and the new mechanism at the same time, that might be nice, but it's fine to remove the old mechanism as part of the PR too. Maybe the new mechanism dominates the old, and if it doesn't we can figure out how to get them to coexist after the fact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant