Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PinSage sampling with Nodeflow #1206

Closed
fiorinin opened this issue Jan 14, 2020 · 3 comments
Closed

PinSage sampling with Nodeflow #1206

fiorinin opened this issue Jan 14, 2020 · 3 comments

Comments

@fiorinin
Copy link

🚀 Feature

Nodeflow support for PinSage.

Motivation

I'm trying to scale up PinSage a bit (2.8M nodes), in order to assess its performances on another dataset. Currently, Nodeflow isn't integrated in the example and I'm struggling to adapt this part of the code — I'm still learning DGL.

Alternatives

I understand this should be released with 0.5. Could you please give me an outline of the steps to be taken in order to implement a Nodeflow equivalent of the current random walk?

Pitch

I'd like to see a prototype of a Nodeflow integration for this bit, or get some help in implementing it myself.

Thanks a lot!

@BarclayII
Copy link
Collaborator

Unfortunately, I was struggling with integrating NodeFlow with PinSAGE as well. That's why we had the initiative of implementing the new sampler spec #1199 in the first place.

Once the new sampling spec is implemented, we will gradually deprecate NodeFlow in favor of the new one.

@fiorinin
Copy link
Author

"Glad" to see I'm not the only one then! :)
Thanks so much for the summary, it's definitely helpful since finding information on overall progress is otherwise complicated.

@jermainewang
Copy link
Member

Close this and let's move the discussion to the open PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants