Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sparse] Remove Python DiagMatrix class and represent it as a SparseMatrix. #5367

Closed
czkkkkkk opened this issue Feb 23, 2023 · 0 comments · Fixed by #5444
Closed

[Sparse] Remove Python DiagMatrix class and represent it as a SparseMatrix. #5367

czkkkkkk opened this issue Feb 23, 2023 · 0 comments · Fixed by #5444
Assignees
@czkkkkkk
Labels
topic: Sparse API Work items to implement the new sparse matrix APIs
Milestone
2023 04.15 Sparse...

Comments

@czkkkkkk
Copy link
Collaborator

czkkkkkk commented Feb 23, 2023 •
edited
Loading

🔨Work Item

IMPORTANT:

  • This template is only for dev team to track project progress. For feature request or bug report, please use the corresponding issue templates.
  • DO NOT create a new work item if the purpose is to fix an existing issue or feature request. We will directly use the issue in the project tracker.

Project tracker: https://github.com/orgs/dmlc/projects/2

There are two PRs for this issue.

  1. Support C++ Diag sparse format. ([Sparse] Support Diag sparse format in C++ #5432)
  2. Remove DiagMatrix in Python and enable the Python sparse matrix with C++ Diag sparse matrix.

Description

Depending work items or issues
@czkkkkkk czkkkkkk added the topic: Sparse API Work items to implement the new sparse matrix APIs label Feb 23, 2023
@czkkkkkk czkkkkkk added this to the 2023 Sparse API Improvement milestone Feb 23, 2023
@czkkkkkk czkkkkkk self-assigned this Feb 23, 2023
This was referenced Mar 7, 2023
Merged
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@czkkkkkk czkkkkkk

Labels
topic: Sparse API Work items to implement the new sparse matrix APIs
Projects
DGL Project Tracker
Archived in project
Milestone
2023 04.15 Sparse API Improvement
Development

Successfully merging a pull request may close this issue.

[Sparse] Remove the Python DiagMatrix class czkkkkkk/dgl
1 participant
@czkkkkkk