Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Building fail on Mac M1. #5610

Closed
czkkkkkk opened this issue Apr 25, 2023 · 2 comments · Fixed by #5626
Closed

[CMake] Building fail on Mac M1. #5610

czkkkkkk opened this issue Apr 25, 2023 · 2 comments · Fixed by #5626
Assignees

Comments

@czkkkkkk
Copy link
Collaborator

🐛 Bug

When building on Mac M1, the CC compiler cannot find "pthread.h".
image

This is bacause #5497 uses CMAKE_C_COMPILER for building libxsmm, which is "/Library/Developer/CommandLineTools/usr/bin/cc" on Mac M1.

However, if I simply remove this change and use "/usr/bin/cc", other errors popup.

image

To Reproduce

Expected behavior

Environment

  • DGL Version (e.g., 1.0): master
  • Backend Library & Version (e.g., PyTorch 0.4.1, MXNet/Gluon 1.3):
  • OS (e.g., Linux): mac m1
  • How you installed DGL (conda, pip, source):
  • Build command you used (if compiling from source):
  • Python version:
  • CUDA/cuDNN version (if applicable):
  • GPU models and configuration (e.g. V100):
  • Any other relevant information:

Additional context

@itaraban
Copy link
Collaborator

itaraban commented Apr 27, 2023

@czkkkkkk could you please check my changes(#5626) on your machine?

@czkkkkkk
Copy link
Collaborator Author

@czkkkkkk could you please check my changes(#5626) on your machine?

Sure! Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants