Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] extend regression tests for pipelining optimization #7121

Closed
Rhett-Ying opened this issue Feb 19, 2024 · 3 comments
Closed

[GraphBolt] extend regression tests for pipelining optimization #7121

Rhett-Ying opened this issue Feb 19, 2024 · 3 comments
Assignees
Labels
Work Item Work items tracked in project tracker

Comments

@Rhett-Ying
Copy link
Collaborator

🔨Work Item

IMPORTANT:

  • This template is only for dev team to track project progress. For feature request or bug report, please use the corresponding issue templates.
  • DO NOT create a new work item if the purpose is to fix an existing issue or feature request. We will directly use the issue in the project tracker.

Project tracker: https://github.com/orgs/dmlc/projects/2

Description

we need to extend the regression tests to cover sample_layer_neigbor and dataloader's overlap_graph_sampling arguments to verify the optimization in #7039.

Depending work items or issues

@Rhett-Ying Rhett-Ying added the Work Item Work items tracked in project tracker label Feb 19, 2024
@Rhett-Ying
Copy link
Collaborator Author

@mfbalin please add more context to help @caojy1998 on this work item.

@mfbalin
Copy link
Collaborator

mfbalin commented Feb 19, 2024

We can modify the https://github.com/dmlc/dgl/blob/master/examples/sampling/graphbolt/node_classification.py to add a sampler option to switch between sample_neighbors and sample_layer_neighbors.

Also, a boolean argument called --overlap_graph_fetch to be passed into the gb.Dataloader, https://docs.dgl.ai/en/latest/generated/dgl.graphbolt.DataLoader.html#dgl.graphbolt.DataLoader.

The regression tests will then need to be updated to cover the combination of the relevant variables, note that overlap_graph_fetch is applicable only for the GPU.

@caojy1998
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Work Item Work items tracked in project tracker
Projects
None yet
Development

No branches or pull requests

3 participants