-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jest reports BroadcastChannel leak #52
Comments
Thanks for the PR @erictheswift. I'll release a patch in a bit |
https://github.com/dmonad/lib0/actions/runs/3931623661/jobs/6723124025#step:6:105 2.0.59 patch build failed because of temporal test machine slowdown? |
I think node made a certain function faster. You don't have to worry about it. |
The function is still slower 90% of the time. Eventually, I'll move to the native encoding approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch
lib0@0.2.52
for the project I'm working on.After I updated to node@18 and jest@28 I found out jest reports some of my tests leak.
I found out that broadcastchannel module keeps BroadcastChannel alive for every room even with zero subscribers.
Here is the diff that solved my problem:
This issue body was partially generated by patch-package.
The text was updated successfully, but these errors were encountered: