Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing close method on LocalStoragePolyfill #61

Closed
ryanb opened this issue Mar 20, 2023 · 2 comments
Closed

Missing close method on LocalStoragePolyfill #61

ryanb opened this issue Mar 20, 2023 · 2 comments
Assignees
@dmonad
Labels
bug Something isn't working

Comments

@ryanb
Copy link

ryanb commented Mar 20, 2023

I'm seeing channel.bc.close is not a function when attempting to disconnect a broadcast channel. This is showing up on my CI server when attempting to upgrade lib0 beyond 0.2.58. I believe this was introduced in this commit which added a call to channel.bc.close.

I assume my CI server is using LocalStoragePolyfill which doesn't respond to close. Should that method be added?

I can provide further details on this if needed.
@ryanb ryanb added the bug Something isn't working label Mar 20, 2023
@dmonad dmonad closed this as completed in dd3f8f4 Mar 20, 2023
@dmonad
Copy link
Owner

dmonad commented Mar 20, 2023

Right, thanks! I fixed the issue in 0.2.70.

@ryanb
Copy link
Author

ryanb commented Mar 20, 2023

Wow, you're fast. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmonad dmonad

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryanb @dmonad