Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RC releases zip files should be named accordingly #3238

Closed
valadas opened this issue Nov 5, 2019 · 1 comment
Closed

RC releases zip files should be named accordingly #3238

valadas opened this issue Nov 5, 2019 · 1 comment
Assignees
@donker @valadas
Labels
Type: Build/Release
Milestone
9.4.3

Comments

@valadas
Copy link
Contributor

valadas commented Nov 5, 2019

Description of bug

During release packaging GitVersion is used to set the zip files names. Currently RC releases are named as the official releases. We currently download the zip files and manually rename them when publishing RCs. It would be easy to use SemVer instead of MajorMinorPatch returned from GitVersion for the zip file name in order to save that manual step and ensure we have a unique file name for each RC release without manual intervention.

image
@valadas valadas added the chore label Nov 5, 2019
@valadas valadas added this to the 9.4.3 milestone Nov 5, 2019
@donker
Copy link
Contributor

donker commented Nov 19, 2019

Fxied by #3285

@donker donker closed this as completed Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donker donker

@valadas valadas

Labels
Type: Build/Release
Projects
None yet
Milestone
9.4.3
Development

No branches or pull requests
3 participants
@donker @david-poindexter @valadas