Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Build tests on CI only when needed #5769

Open
radical opened this issue Sep 18, 2024 · 0 comments
Open

[ci] Build tests on CI only when needed #5769

radical opened this issue Sep 18, 2024 · 0 comments

Comments

@radical
Copy link
Member

radical commented Sep 18, 2024

Context:
#5739 (comment)

We currently always build tests on CI even in cases where we don't need to, for example, a codeql build. We should condition the @(ProjectsToBuild) to not include the tests, maybe when $(Test)==false.

<ItemGroup Condition="'$(DotNetBuildFromSource)' != 'true' and '$(DotNetBuild)' != 'true'">
<ProjectToBuild Include="$(RepoRoot)src\**\*.csproj" Exclude="$(RepoRoot)src\Aspire.ProjectTemplates\templates\**\*.csproj" />
<ProjectToBuild Include="$(RepoRoot)eng\dcppack\**\*.csproj" />
<ProjectToBuild Include="$(RepoRoot)eng\dashboardpack\**\*.csproj" />
<ProjectToBuild Include="$(RepoRoot)playground\**\*.csproj" />
<ProjectToBuild Include="$(RepoRoot)tests\**\*.csproj" />
</ItemGroup>

cc @eerhardt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant