From b52ca8197768d3ac2b4623d19d322128c0649cda Mon Sep 17 00:00:00 2001 From: Shay Rojansky Date: Sat, 4 Feb 2023 14:07:28 +0200 Subject: [PATCH] Remove unchecks in SQL Server type mappings (#30164) Closes #30111 --- .../Storage/Internal/SqlServerDateTimeOffsetTypeMapping.cs | 2 +- .../Storage/Internal/SqlServerDateTimeTypeMapping.cs | 2 +- .../Storage/Internal/SqlServerDecimalTypeMapping.cs | 4 ++-- .../Storage/Internal/SqlServerTimeSpanTypeMapping.cs | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/EFCore.SqlServer/Storage/Internal/SqlServerDateTimeOffsetTypeMapping.cs b/src/EFCore.SqlServer/Storage/Internal/SqlServerDateTimeOffsetTypeMapping.cs index 742d677352d..6cc2a29dcf8 100644 --- a/src/EFCore.SqlServer/Storage/Internal/SqlServerDateTimeOffsetTypeMapping.cs +++ b/src/EFCore.SqlServer/Storage/Internal/SqlServerDateTimeOffsetTypeMapping.cs @@ -108,7 +108,7 @@ protected override void ConfigureParameter(DbParameter parameter) if (Precision.HasValue) { // Workaround for inconsistent definition of precision/scale between EF and SQLClient for VarTime types - parameter.Scale = unchecked((byte)Precision.Value); + parameter.Scale = (byte)Precision.Value; } } } diff --git a/src/EFCore.SqlServer/Storage/Internal/SqlServerDateTimeTypeMapping.cs b/src/EFCore.SqlServer/Storage/Internal/SqlServerDateTimeTypeMapping.cs index 09c71684232..9139d297df2 100644 --- a/src/EFCore.SqlServer/Storage/Internal/SqlServerDateTimeTypeMapping.cs +++ b/src/EFCore.SqlServer/Storage/Internal/SqlServerDateTimeTypeMapping.cs @@ -106,7 +106,7 @@ protected override void ConfigureParameter(DbParameter parameter) { // SQL Server accepts a scale, but in EF a scale along isn't supported (without precision). // So the actual value is contained as precision in scale, but sent as Scale to SQL Server. - parameter.Scale = unchecked((byte)Precision.Value); + parameter.Scale = (byte)Precision.Value; } } diff --git a/src/EFCore.SqlServer/Storage/Internal/SqlServerDecimalTypeMapping.cs b/src/EFCore.SqlServer/Storage/Internal/SqlServerDecimalTypeMapping.cs index eb9cc5141b5..02d3e867b3c 100644 --- a/src/EFCore.SqlServer/Storage/Internal/SqlServerDecimalTypeMapping.cs +++ b/src/EFCore.SqlServer/Storage/Internal/SqlServerDecimalTypeMapping.cs @@ -92,12 +92,12 @@ protected override void ConfigureParameter(DbParameter parameter) if (Precision.HasValue) { - parameter.Precision = unchecked((byte)Precision.Value); + parameter.Precision = (byte)Precision.Value; } if (Scale.HasValue) { - parameter.Scale = unchecked((byte)Scale.Value); + parameter.Scale = (byte)Scale.Value; } } } diff --git a/src/EFCore.SqlServer/Storage/Internal/SqlServerTimeSpanTypeMapping.cs b/src/EFCore.SqlServer/Storage/Internal/SqlServerTimeSpanTypeMapping.cs index b5ed9a76c45..ea5f8602f46 100644 --- a/src/EFCore.SqlServer/Storage/Internal/SqlServerTimeSpanTypeMapping.cs +++ b/src/EFCore.SqlServer/Storage/Internal/SqlServerTimeSpanTypeMapping.cs @@ -85,7 +85,7 @@ protected override void ConfigureParameter(DbParameter parameter) if (Precision.HasValue) { - parameter.Scale = unchecked((byte)Precision.Value); + parameter.Scale = (byte)Precision.Value; } }