From c6518887a89ea72c96236e42900f4427cc24858a Mon Sep 17 00:00:00 2001
From: Brice Lambson <brice@bricelam.net>
Date: Thu, 3 Dec 2020 18:25:27 -0800
Subject: [PATCH] Remove .rd.xml files

Resolves #18490
---
 Directory.Build.props                         |   4 -
 ...soft.EntityFrameworkCore.Relational.rd.xml |   8 --
 ...osoft.EntityFrameworkCore.SqlServer.rd.xml |   8 --
 ...icrosoft.EntityFrameworkCore.Sqlite.rd.xml |   8 --
 .../Microsoft.EntityFrameworkCore.rd.xml      | 104 ------------------
 .../Properties/Microsoft.Data.Sqlite.rd.xml   |  10 --
 6 files changed, 142 deletions(-)
 delete mode 100644 src/EFCore.Relational/Properties/Microsoft.EntityFrameworkCore.Relational.rd.xml
 delete mode 100644 src/EFCore.SqlServer/Properties/Microsoft.EntityFrameworkCore.SqlServer.rd.xml
 delete mode 100644 src/EFCore.Sqlite.Core/Properties/Microsoft.EntityFrameworkCore.Sqlite.rd.xml
 delete mode 100644 src/EFCore/Properties/Microsoft.EntityFrameworkCore.rd.xml
 delete mode 100644 src/Microsoft.Data.Sqlite.Core/Properties/Microsoft.Data.Sqlite.rd.xml

diff --git a/Directory.Build.props b/Directory.Build.props
index 99f8484a6ad..0d2129ff2a8 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -35,8 +35,4 @@
   <PropertyGroup>
     <NoWarn>$(NoWarn.Replace(';1591', ''))</NoWarn>
   </PropertyGroup>
-
-  <ItemGroup>
-    <EmbeddedResource Include="**\*.rd.xml" />
-  </ItemGroup>
 </Project>
diff --git a/src/EFCore.Relational/Properties/Microsoft.EntityFrameworkCore.Relational.rd.xml b/src/EFCore.Relational/Properties/Microsoft.EntityFrameworkCore.Relational.rd.xml
deleted file mode 100644
index 67137319a99..00000000000
--- a/src/EFCore.Relational/Properties/Microsoft.EntityFrameworkCore.Relational.rd.xml
+++ /dev/null
@@ -1,8 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-
-<Directives xmlns="http://schemas.microsoft.com/netfx/2013/01/metadata">
-  <Library>
-    <!-- TODO optimize this for types that actually need reflection -->
-    <Assembly Name="Microsoft.EntityFrameworkCore.Relational" Dynamic="Required All" />
-  </Library>
-</Directives>
\ No newline at end of file
diff --git a/src/EFCore.SqlServer/Properties/Microsoft.EntityFrameworkCore.SqlServer.rd.xml b/src/EFCore.SqlServer/Properties/Microsoft.EntityFrameworkCore.SqlServer.rd.xml
deleted file mode 100644
index 5894c064e8a..00000000000
--- a/src/EFCore.SqlServer/Properties/Microsoft.EntityFrameworkCore.SqlServer.rd.xml
+++ /dev/null
@@ -1,8 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-
-<Directives xmlns="http://schemas.microsoft.com/netfx/2013/01/metadata">
-  <Library>
-    <Assembly Name="Microsoft.EntityFrameworkCore.SqlServer" Dynamic="Required All" />
-    <!-- TODO optimize this for types that actually need reflection -->
-  </Library>
-</Directives>
\ No newline at end of file
diff --git a/src/EFCore.Sqlite.Core/Properties/Microsoft.EntityFrameworkCore.Sqlite.rd.xml b/src/EFCore.Sqlite.Core/Properties/Microsoft.EntityFrameworkCore.Sqlite.rd.xml
deleted file mode 100644
index ca1833ccbdf..00000000000
--- a/src/EFCore.Sqlite.Core/Properties/Microsoft.EntityFrameworkCore.Sqlite.rd.xml
+++ /dev/null
@@ -1,8 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-
-<Directives xmlns="http://schemas.microsoft.com/netfx/2013/01/metadata">
-  <Library>
-    <!-- TODO optimize this for types that actually need reflection -->
-    <Assembly Name="Microsoft.EntityFrameworkCore.Sqlite" Dynamic="Required All" />
-  </Library>
-</Directives>
\ No newline at end of file
diff --git a/src/EFCore/Properties/Microsoft.EntityFrameworkCore.rd.xml b/src/EFCore/Properties/Microsoft.EntityFrameworkCore.rd.xml
deleted file mode 100644
index e9956a81e95..00000000000
--- a/src/EFCore/Properties/Microsoft.EntityFrameworkCore.rd.xml
+++ /dev/null
@@ -1,104 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-
-<Directives xmlns="http://schemas.microsoft.com/netfx/2013/01/metadata">
-  <Library>
-    <Assembly Name="Microsoft.EntityFrameworkCore" Dynamic="Required All" />
-
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Object}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Boolean}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Byte}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.SByte}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Char}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Decimal}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Double}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Single}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Int32}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.UInt32}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Int64}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.UInt64}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Int16}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.UInt16}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Guid}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.DateTime}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.DateTimeOffset}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.TimeSpan}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Nullable{System.Boolean}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Nullable{System.Byte}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Nullable{System.SByte}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Nullable{System.Char}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Nullable{System.Decimal}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Nullable{System.Double}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Nullable{System.Single}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Nullable{System.Int32}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Nullable{System.UInt32}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Nullable{System.Int64}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Nullable{System.UInt64}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Nullable{System.Int16}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Nullable{System.UInt16}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Nullable{System.Guid}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Nullable{System.DateTime}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Nullable{System.DateTimeOffset}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertyGetter{System.Object, System.Nullable{System.TimeSpan}}" Dynamic="Required Public" />
-
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Object}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Boolean}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Byte}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.SByte}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Char}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Decimal}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Double}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Single}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Int32}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.UInt32}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Int64}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.UInt64}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Int16}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.UInt16}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Guid}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.DateTime}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.DateTimeOffset}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.TimeSpan}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Nullable{System.Boolean}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Nullable{System.Byte}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Nullable{System.SByte}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Nullable{System.Char}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Nullable{System.Decimal}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Nullable{System.Double}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Nullable{System.Single}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Nullable{System.Int32}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Nullable{System.UInt32}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Nullable{System.Int64}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Nullable{System.UInt64}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Nullable{System.Int16}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Nullable{System.UInt16}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Nullable{System.Guid}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Nullable{System.DateTime}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Nullable{System.DateTimeOffset}}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.Metadata.Internal.ClrPropertySetter{System.Object, System.Nullable{System.TimeSpan}}" Dynamic="Required Public" />
-
-    <Type Name="Microsoft.EntityFrameworkCore.ChangeTracking.Internal.DependentsMap{System.Object}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.ChangeTracking.Internal.DependentsMap{System.Guid}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.ChangeTracking.Internal.DependentsMap{System.Int32}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.ChangeTracking.Internal.DependentsMap{System.Nullable{System.Int32}}" Dynamic="Required Public" />
-
-    <Type Name="Microsoft.EntityFrameworkCore.ChangeTracking.Internal.IdentityMap{System.Guid}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.ChangeTracking.Internal.IdentityMap{System.Int32}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.ChangeTracking.Internal.NullableKeyIdentityMap{System.Object}" Dynamic="Required Public" />
-    <Type Name="Microsoft.EntityFrameworkCore.ChangeTracking.Internal.NullableKeyIdentityMap{System.Nullable{System.Int32}}" Dynamic="Required Public" />
-
-    <Type Name="Microsoft.EntityFrameworkCore.Query.EntityMaterializerSource" Dynamic="Required Public">
-      <MethodInstantiation Name="TryReadValue" Arguments="System.Object" Dynamic="Required" />
-      <MethodInstantiation Name="TryReadValue" Arguments="System.Guid" Dynamic="Required" />
-      <MethodInstantiation Name="TryReadValue" Arguments="System.Int32" Dynamic="Required" />
-      <MethodInstantiation Name="TryReadValue" Arguments="System.Nullable{System.Int32}" Dynamic="Required" />
-    </Type>
-
-    <Type Name="Microsoft.EntityFrameworkCore.ChangeTracking.ChangeTracker" Dynamic="Required Public">
-      <MethodInstantiation Name="Entries" Arguments="System.Object" Dynamic="Required" />
-    </Type>
-
-    <Type Name="System.Collections.Generic.Dictionary{System.Object, System.Object}" Dynamic="Required Public" />
-
-    <Type Name="System.Collections.ArrayList" Dynamic="Required All" />
-  </Library>
-</Directives>
\ No newline at end of file
diff --git a/src/Microsoft.Data.Sqlite.Core/Properties/Microsoft.Data.Sqlite.rd.xml b/src/Microsoft.Data.Sqlite.Core/Properties/Microsoft.Data.Sqlite.rd.xml
deleted file mode 100644
index 4549c8a4ef0..00000000000
--- a/src/Microsoft.Data.Sqlite.Core/Properties/Microsoft.Data.Sqlite.rd.xml
+++ /dev/null
@@ -1,10 +0,0 @@
-<!--
-    This file contains Runtime Directives used by .NET Native.
--->
-
-<Directives xmlns="http://schemas.microsoft.com/netfx/2013/01/metadata">
-  <Library>
-    <Type Name="Windows.Storage.ApplicationData" Dynamic="Required All" />
-    <Type Name="Windows.Storage.StorageFolder" Dynamic="Required All" />
-  </Library>
-</Directives>
\ No newline at end of file