Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior of query filters with navigations vs. includes #11957

Closed
tuespetre opened this issue May 10, 2018 · 3 comments
Closed

Behavior of query filters with navigations vs. includes #11957

tuespetre opened this issue May 10, 2018 · 3 comments

Comments

@tuespetre
Copy link
Contributor

Last night I was working on some tests in my project and ran across this one test that exhibits behavior that I didn't expect:

https://github.com/aspnet/EntityFrameworkCore/blob/69f870ab1f32b3185c3599887fbe020c0f70c445/src/EFCore.Specification.Tests/Query/FiltersTestBase.cs#L114-L120

https://github.com/aspnet/EntityFrameworkCore/blob/8790253a195064fcd8b0151fb15165523489731e/test/EFCore.SqlServer.FunctionalTests/Query/FiltersSqlServerTest.cs#L165-L181

The Customer query filter is applied to the include, but not to the expansion of the Customer navigation inside of the Order query filter. I'm not sure if this is semantically correct, or if this just avoids the dreaded infinite circular application of query filters between two or more entity types. If this is by design you can yell at me and click on 'close issue' so hard your mouse and/or trackpad shatters. 😉

@smitpatel
Copy link
Member

Filters need to be applied after running nav expansion on filter.

@smitpatel
Copy link
Member

Assigning to @maumar
When navigations expands into new entityqueryables, it should introduce associated query filters automatically.

@smitpatel smitpatel removed their assignment Jan 25, 2019
@smitpatel
Copy link
Member

Duplicate of #13361

@smitpatel smitpatel marked this as a duplicate of #13361 May 28, 2019
@smitpatel smitpatel removed this from the 3.0.0 milestone May 28, 2019
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants