Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relational: Consider always generating distinct column names in final projection (aliasing when needed) #14526

Closed
divega opened this issue Jan 26, 2019 · 0 comments
Closed

Relational: Consider always generating distinct column names in final projection (aliasing when needed) #14526

divega opened this issue Jan 26, 2019 · 0 comments
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.

Comments

@divega
Copy link
Contributor

divega commented Jan 26, 2019

This is something we don't do today because it is not strictly required to have distinct column names and our materialization dereferences columns by ordinal.

It would be necessary for #14525, unless we assume the user provided SQL returns columns in the exact same order that our queries would. It is also convenient if we ever want to take advantage of FOR JSON, or if the user wants to take the SQL we generate and manipulate it in any way.
@ajcvickers ajcvickers added this to the Backlog milestone Jan 28, 2019
@ajcvickers ajcvickers removed this from the Backlog milestone Nov 10, 2021
@ajcvickers ajcvickers added the closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. label Mar 10, 2022
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@divega @ajcvickers @smitpatel