Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic KeyBuilder #15380

Closed
AndriySvyryd opened this issue Apr 16, 2019 · 4 comments · Fixed by #20516
Closed

Add generic KeyBuilder #15380

AndriySvyryd opened this issue Apr 16, 2019 · 4 comments · Fixed by #20516
Assignees
@lajones
Labels
area-model-building breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-enhancement
Milestone
5.0.0

Comments

@AndriySvyryd
Copy link
Member

No description provided.

@ajcvickers ajcvickers added this to the 3.0.0 milestone Apr 19, 2019
@ajcvickers
Copy link
Member

Only a binary break, so it can come in late.

@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog May 10, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 5.0.0 Nov 18, 2019
@ajcvickers ajcvickers self-assigned this Nov 18, 2019
@lajones lajones assigned lajones and unassigned ajcvickers and AndriySvyryd Apr 3, 2020
@lajones lajones removed the poachable label Apr 3, 2020
@lajones
Copy link
Contributor

lajones commented Apr 3, 2020

Poaching.

@lajones lajones mentioned this issue Apr 3, 2020
Merged
@lajones lajones added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Apr 3, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview4 Apr 20, 2020
@ajcvickers
Copy link
Member

@AndriySvyryd Should this still be marked as fixed? Should we file a new issue for HasKey returning the generic key builder?

@AndriySvyryd
Copy link
Member Author

The generic builder is in the code so this is still fixed. I don't think it's worth it to keep tracking this.

@ajcvickers ajcvickers modified the milestones: 5.0.0-preview4, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lajones lajones

Labels
area-model-building breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Fix for 15380. Generic KeyBuilder. dotnet/efcore
3 participants
@ajcvickers @lajones @AndriySvyryd