Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider-agnostic timeouts #18456

Open
ajcvickers opened this issue Oct 18, 2019 · 2 comments
Open

Provider-agnostic timeouts #18456

ajcvickers opened this issue Oct 18, 2019 · 2 comments

Comments

@ajcvickers
Copy link
Member

The idea here is to have a core-level API to set a "database access timeout". Every provider would then use the value set to configure appropriate timeouts in the lower-level APIs that the provider uses. For example, a relational provider would use this to set both command and connection timeouts.

Any call to a more provider-specific API would override anything set here.

This has two advantages:

@ajcvickers ajcvickers added this to the Backlog milestone Oct 21, 2019
@ajcvickers ajcvickers added the good first issue This issue should be relatively straightforward to fix. label Oct 21, 2019
@sputier
Copy link

sputier commented Oct 25, 2019

As a first step into the EF Core source, I'm trying to think about a way to solve this issue. So far, I thought about adding a DbContextOptionsBuilder.SetDatabaseAccessTimeout method, which would set a CoreOptionsExtension value.
Could this be a good start to handle this issue ?

@AndriySvyryd
Copy link
Member

@sputier That sounds reasonable, you can also open a WIP/draft PR if you aren't sure about what needs to be done next. Don't forget to add tests for different providers.

@ajcvickers ajcvickers removed the good first issue This issue should be relatively straightforward to fix. label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants