Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos: avoid generating SQL that could clash with keywords #20613

Closed
AndriySvyryd opened this issue Apr 13, 2020 · 1 comment
Closed

Cosmos: avoid generating SQL that could clash with keywords #20613

AndriySvyryd opened this issue Apr 13, 2020 · 1 comment
Labels
area-cosmos area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
5.0.0

Comments

@AndriySvyryd
Copy link
Member

Originally from @smitpatel

May be we should generate SQL this way
Then we can probably avoid all clashes?

SELECT VALUE { "Value" : c["OrderID"] }
FROM root c
WHERE (c["Discriminator"] = "Order")
@AndriySvyryd AndriySvyryd mentioned this issue Apr 14, 2020
Merged
@ajcvickers ajcvickers added this to the 5.0.0 milestone Apr 17, 2020
@AndriySvyryd
Copy link
Member Author

Fixed in 2818db7

@AndriySvyryd AndriySvyryd removed their assignment Jun 20, 2020
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 20, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview7 Jun 22, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview7, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-cosmos area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@ajcvickers @AndriySvyryd