Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated dependency on SqlClient package #21184

Closed
arjanvanbekkum opened this issue Jun 9, 2020 · 5 comments
Closed

Outdated dependency on SqlClient package #21184

arjanvanbekkum opened this issue Jun 9, 2020 · 5 comments
Labels
area-global closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported Servicing-approved type-enhancement
Milestone

Comments

@arjanvanbekkum
Copy link

There is a bug in the Mircosoft.Data.SqlClient package version 1.0.19x, if you use async queries in a container on .NET Core 3.1, it random creates locks on the database. This bug is fixed in version 1.1.1 of the Mircosoft.Data.SqlClient package.

Please update the minimum version of this dependency to 1.1.1. instead of 1.0.19x

for more information please read:
https://arjanvanbekkum.github.io/blog/2020/06/08/Process-End-NET-Core-EF-Core

Further technical details

EF Core version: 3.1.4
Database provider: Microsoft.EntityFrameworkCore.SqlServer
Target framework: .NET Core 3.1
Operating system: Win10, Linux Containers
IDE: Visual Studio 2019 16.5.4

@roji
Copy link
Member

roji commented Jun 9, 2020

@arjanvanbekkum we don't update dependency versions to new minor/major versions in EF Core patch versions - in the 5.0 the SqlClient version has already been updated.

However, there's nothing preventing you from taking a dependency on a newer version of SqlClient yourself, in your own project.

@arjanvanbekkum
Copy link
Author

We already updated our project to use a newer version of the SqlClient. This bug has the potential to completely stop your software from working correctly , it took us a few days to figure out what was wrong.

If you could update the dependency on the EF package to use 1.1.1 you can prevent this bug appearing in other projects as well.

When using Visual Studio you are not actively triggered for updates on dependency packages so you manually figure out which package needs an update.
I know Visual Studio is not your problem, but in this case you can prevent this bug and save a lot of time and money for teams running in to this issue.

@ajcvickers
Copy link
Member

See #20377. We have been holding off on this, but the plan is still to update once we're confidence that the package we update to is fully stable.

@arjanvanbekkum
Copy link
Author

Thanks @ajcvickers. We are already running with version 1.1.1 of the sql client, no problems so far.

@ajcvickers ajcvickers removed this from the 5.0.0 milestone Jun 20, 2020
@ajcvickers ajcvickers added this to the 3.1.7 milestone Jul 6, 2020
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 6, 2020
@ajcvickers
Copy link
Member

PR: #20377

@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-global closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported Servicing-approved type-enhancement
Projects
None yet
Development

No branches or pull requests

3 participants