Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Default Join Entity Type Name #21565

Closed
lajones opened this issue Jul 8, 2020 · 0 comments · Fixed by #21584
Closed

Update Default Join Entity Type Name #21565

lajones opened this issue Jul 8, 2020 · 0 comments · Fixed by #21584
Assignees
@lajones
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
5.0.0

Comments

@lajones
Copy link
Contributor

lajones commented Jul 8, 2020 •
edited
Loading

At the moment we use "Join_{leftETSN}_{rightETSN}" where {leftETSN} = leftEntityType.ShortName(), {rightETSN} = rightEntityType.ShortName() as the default name of the join entity we create for implicit many-to-many joins.

At the Design Meeting on July 8 we decided to update this to just "{leftETSN}{rightETSN}".
@lajones lajones self-assigned this Jul 8, 2020
@lajones lajones changed the title Update Default Join Entity Name Update Default Join Entity Type Name Jul 8, 2020
@lajones lajones mentioned this issue Jul 10, 2020
Merged
@ajcvickers ajcvickers added this to the 5.0.0 milestone Jul 10, 2020
@lajones lajones mentioned this issue Jul 10, 2020
Merged
@lajones lajones added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 10, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview8 Jul 14, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview8, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lajones lajones

Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Fix for issue 21565. Update default Join Entity name. dotnet/efcore
2 participants
@ajcvickers @lajones