Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to managing projection/column aliases via ISqlAliasManager as well #32821

Open
roji opened this issue Jan 15, 2024 · 0 comments
Open

Switch to managing projection/column aliases via ISqlAliasManager as well #32821

roji opened this issue Jan 15, 2024 · 0 comments

Comments

@roji
Copy link
Member

roji commented Jan 15, 2024

#32785 redid table alias management, introducing a new "SQL alias manager" which is responsible for tracking which aliases are already in use in a query, and ensuring new ones are unique with respect to those. It also concentrates the actual logic of what table aliases look like (first char, lowercase) in a single place, so that this logic can be tweaked/overridden.

However, this didn't make any changes to projection (i.e. column) alias management - these are still hard-coded in various places. We should also refactor that logic into the new SQL manager.

/cc @maumar

@roji roji changed the title Switch to managing column aliases via ISqlAliasManager as well Switch to managing projection/column aliases via ISqlAliasManager as well Jan 15, 2024
@ajcvickers ajcvickers added this to the Backlog milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants