Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse shapers across queries #34445

Open
roji opened this issue Aug 15, 2024 · 0 comments
Open

Reuse shapers across queries #34445

roji opened this issue Aug 15, 2024 · 0 comments

Comments

@roji
Copy link
Member

roji commented Aug 15, 2024

We currently produce a shaper for each query we compile; since as many queries end up having identical shapers, we can have a cache which allows queries to reuse shapers. This would help reduce binary size for NativeAOT, and would also help regular JIT application performance as ew need to compile less shapers at runtime.

This is basically about figuring out the correct, comprehensive cache key for shapers, and implementing the caching.

Note that we also have #32923, which is about reusing materializers across queries (with materializers being the narrower piece of code that materializes an instance from DbDataReader, and therefore doesn't care about tracking/no-tracking, split query....). Both caches can be done independently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant