Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Refactor ReverseEngineer EndToEnd tests #8594

Closed
smitpatel opened this issue May 25, 2017 · 2 comments
Closed

Test: Refactor ReverseEngineer EndToEnd tests #8594

smitpatel opened this issue May 25, 2017 · 2 comments

Comments

@smitpatel
Copy link
Member

Our current testing infra test rev eng in following way.

  1. Create DB
  2. Rev eng DB and generate files
  3. Compare generated files to expected files.

For every new type of code we generate, we need to add db creation and expected files.
Code generation is done by EFCore.Design not the provider.
We don't verify individual components making it harder to have good test coverage. Like we are missing KeyAttribute.

It may need some design on what we want to test, what we want to provide to provider-writers to test etc.

@smitpatel
Copy link
Member Author

From @lajones

Good catch, but I would like to have at least one test where we do generate it because it is different from the default. Can we arrange that somehow (e.g. rename a PK or two in the E2E.sql file)?

@smitpatel
Copy link
Member Author

Duplicate of #9111 already fixed

@bricelam bricelam removed this from the Backlog milestone Jan 2, 2018
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants