From 70a236ca8a2f4bccd15af975bd8ba1ea5d8f74e5 Mon Sep 17 00:00:00 2001 From: Shay Rojansky Date: Thu, 7 May 2020 12:16:11 +0200 Subject: [PATCH] Replace decimal with double in benchmarks Because Sqlite doesn't support operations on decimals (e.g. ordering) Fixes #20822 --- benchmark/EF.Benchmarks.Shared/Models/Orders/OrderLine.cs | 2 +- benchmark/EF.Benchmarks.Shared/Models/Orders/Product.cs | 4 ++-- .../EF6.SqlServer.Benchmarks/Query/QueryCompilationTests.cs | 2 +- benchmark/EFCore.Benchmarks/Query/QueryCompilationTests.cs | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/benchmark/EF.Benchmarks.Shared/Models/Orders/OrderLine.cs b/benchmark/EF.Benchmarks.Shared/Models/Orders/OrderLine.cs index 80a2d3744f5..3461d2873fc 100644 --- a/benchmark/EF.Benchmarks.Shared/Models/Orders/OrderLine.cs +++ b/benchmark/EF.Benchmarks.Shared/Models/Orders/OrderLine.cs @@ -7,7 +7,7 @@ public class OrderLine { public int OrderLineId { get; set; } public int Quantity { get; set; } - public decimal Price { get; set; } + public double Price { get; set; } public bool IsSubjectToTax { get; set; } public string SpecialRequests { get; set; } public bool IsShipped { get; set; } diff --git a/benchmark/EF.Benchmarks.Shared/Models/Orders/Product.cs b/benchmark/EF.Benchmarks.Shared/Models/Orders/Product.cs index 5c18ff5bd4e..72a660698c0 100644 --- a/benchmark/EF.Benchmarks.Shared/Models/Orders/Product.cs +++ b/benchmark/EF.Benchmarks.Shared/Models/Orders/Product.cs @@ -12,8 +12,8 @@ public class Product public string Name { get; set; } public string Description { get; set; } public string SKU { get; set; } - public decimal Retail { get; set; } - public decimal CurrentPrice { get; set; } + public double Retail { get; set; } + public double CurrentPrice { get; set; } public int TargetStockLevel { get; set; } public int ActualStockLevel { get; set; } public int? ReorderStockLevel { get; set; } diff --git a/benchmark/EF6.SqlServer.Benchmarks/Query/QueryCompilationTests.cs b/benchmark/EF6.SqlServer.Benchmarks/Query/QueryCompilationTests.cs index 043cdc65b4d..77446695483 100644 --- a/benchmark/EF6.SqlServer.Benchmarks/Query/QueryCompilationTests.cs +++ b/benchmark/EF6.SqlServer.Benchmarks/Query/QueryCompilationTests.cs @@ -75,7 +75,7 @@ private class DTO public string Description { get; set; } public int ActualStockLevel { get; set; } public string SKU { get; set; } - public decimal Savings { get; set; } + public double Savings { get; set; } public int Surplus { get; set; } } } diff --git a/benchmark/EFCore.Benchmarks/Query/QueryCompilationTests.cs b/benchmark/EFCore.Benchmarks/Query/QueryCompilationTests.cs index 170051c8604..e12c0aab617 100644 --- a/benchmark/EFCore.Benchmarks/Query/QueryCompilationTests.cs +++ b/benchmark/EFCore.Benchmarks/Query/QueryCompilationTests.cs @@ -104,7 +104,7 @@ private class DTO public string Description { get; set; } public int ActualStockLevel { get; set; } public string SKU { get; set; } - public decimal Savings { get; set; } + public double Savings { get; set; } public int Surplus { get; set; } }