Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullness bug - duplicate warning for the same range #17410

Closed
1 of 7 tasks
T-Gro opened this issue Jul 12, 2024 · 0 comments · Fixed by #17477
Closed
1 of 7 tasks

Nullness bug - duplicate warning for the same range #17410

T-Gro opened this issue Jul 12, 2024 · 0 comments · Fixed by #17477
Assignees
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug
Milestone

Comments

@T-Gro
Copy link
Member

T-Gro commented Jul 12, 2024

Issue description

A single line of code produces two identical nullness warnings.

let getLength (x: string | null) = x.Length

image

Choose one or more from the following categories of impact

  • Unexpected nullness warning (false positive in nullness checking, code uses --checknulls and langversion:preview).
  • Missing nullness warning in a case which can produce nulls (false negative, code uses --checknulls and langversion:preview).
  • Breaking change related to older null constructs in code not using the checknulls switch.
  • Breaking change related to generic code and explicit type constraints (null, not null).
  • Type inference issue (i.e. code worked without type annotations before, and applying the --checknulls enforces type annotations).
  • C#/F# interop issue related to nullness metadata.
  • Other (none of the categories above apply).

Operating System

Windows (Default)

What .NET runtime/SDK kind are you seeing the issue on

.NET SDK (.NET Core, .NET 5+)

.NET Runtime/SDK version

No response

Reproducible code snippet and actual behavior

let getLength (x: string | null) = x.Length

image

Possible workarounds

Ignore the warning, use IDE which deduplicates equal warnings for equal ranges.

@T-Gro T-Gro added Bug Needs-Triage Area-Nullness Issues related to handling of Nullable Reference Types labels Jul 12, 2024
@T-Gro T-Gro self-assigned this Jul 12, 2024
@github-actions github-actions bot added this to the Backlog milestone Jul 12, 2024
@T-Gro T-Gro removed their assignment Jul 12, 2024
@T-Gro T-Gro self-assigned this Jul 30, 2024
@T-Gro T-Gro modified the milestones: Backlog, August-2024 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant