Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: NoWarn randomly get ignored in build #9133

Closed
tarekgh opened this issue Aug 16, 2023 · 9 comments · Fixed by #9162
Closed

[Bug]: NoWarn randomly get ignored in build #9133

tarekgh opened this issue Aug 16, 2023 · 9 comments · Fixed by #9162
Assignees
Milestone

Comments

@tarekgh
Copy link
Member

tarekgh commented Aug 16, 2023

Issue Description

The runtime repo CI started randomly fail building projects which uses NoWarn and still the suppressed warning gets fired and breaks the build. The runtime issue showing such failures.

Here is an example suppressing NETSDK1206 and compilation produces error NETSDK1206: Found version-specific or distribution-specific runtime identifier(s): alpine-x64. Affected libraries: SQLitePCLRaw.lib.e_sqlite3.

binlog

Steps to Reproduce

No specific steps as the CI randomly failing.

Expected Behavior

Projects suppressing the warning should build successfully without failing with the suppressed warning

Actual Behavior

The suppressed NETSDK1206 produces randomly the error:
error NETSDK1206: Found version-specific or distribution-specific runtime identifier(s): alpine-x64. Affected libraries: SQLitePCLRaw.lib.e_sqlite3

Analysis

msbuild have a problem not suppressing the warning.

Versions & Configurations

The runtime repo CI runs is using .NET 8 P7 SDK.

@tarekgh tarekgh added bug needs-triage Have yet to determine what bucket this goes in. labels Aug 16, 2023
@JanKrivanek
Copy link
Member

Can this be an analogous case caused be a rootcause in a same code as #8814? @rokonec?

@JaynieBai JaynieBai self-assigned this Aug 17, 2023
@KalleOlaviNiemitalo
Copy link

Does the binlog show NoWarn being translated to MSBuildWarningsAsMessages in the test project? Difficult to find when the log is so large.

@JaynieBai
Copy link
Member

JaynieBai commented Aug 17, 2023

Does the binlog show NoWarn being translated to MSBuildWarningsAsMessages in the test project? Difficult to find when the log is so large.

From the correct build log, it's true to treat the warning as message with NoWarn. But in the failed log it is treated as errors.
image

@JaynieBai JaynieBai removed the needs-triage Have yet to determine what bucket this goes in. label Aug 18, 2023
@JaynieBai
Copy link
Member

@tarekgh I try to repro this issue locally on Mac arm64, when build with ./build.sh -subset tools+libs+libs.tests -rc checked -configuration Release -ci -arch arm64 -framework net8.0 /p:CrossBuild=true /p:ArchiveTests=true
, met the following error, could you help me figure it out?
4258ADFD-8B87-480D-8266-AA6717F2480E

@tarekgh
Copy link
Member Author

tarekgh commented Aug 22, 2023

@ViktorHofer may help with this as the failure is in Microsoft.DotNet.HotReload.Utils.Generator.BuildTool

@ViktorHofer
Copy link
Member

@lambdageek @akoeplinger are the main contributors to hotreload-utils. Can you please take a look?

@akoeplinger
Copy link
Member

Can you try removing the /p:CrossBuild=true ? It's not needed since you're building on arm64 for arm64

@JaynieBai
Copy link
Member

Can you try removing the /p:CrossBuild=true ? It's not needed since you're building on arm64 for arm64

Remove that, but the same errors are still there.

@JanKrivanek
Copy link
Member

Info by @timmydo:

https://cloudbuild.microsoft.com/build/5c51aba5-6861-4aa5-90d5-d4f53de94008?bq=git_snrcode2_master_retail

D:\data\Q\dotnet\9pwfkyv5X45xHLPhGvUGgg\sdk\8.0.100-preview.7.23376.3\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(267,5): warning NETSDK1206: Found version-specific or distribution-specific runtime identifier(s): osx.10.14-arm64, osx.10.14-x64. Affected libraries: Microsoft.ML.OnnxRuntime. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details. [D:\dbs\el\sn2\private\frontend\Answers\services\Flights\Test\Flights.Tests.csproj]

binlog
https://cloudbuild.microsoft.com/stamp/MW_PS12/getfile?path=\CO1PPF547CF2B56\d:\dbs\sh\sn2\0822_092659_1\private\frontend\Answers\services\Flights\Test\Logs\Retail\AnyCPU\msbuild.binlog

text log
https://cloudbuild.microsoft.com/stamp/MW_PS12/getfile?path=\CO1PPF547CF2B56\d:\dbs\sh\sn2\0822_092659_1\private\frontend\Answers\services\Flights\Test\Logs\Retail\AnyCPU\build.log

we aren't building or running on OSX. I'm considering repackaging the onnxruntime nuget myself.

Btw. - the NETSDK1206 only shows as warning in that log:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants